fix: Fork and detach child processes#1
Open
phyber wants to merge 1 commit intoOpenActionPlugins:mainfrom
Open
Conversation
Author
|
Converted to draft to test this some more with more and varied application launches. |
This helps with an issue where previously we did not wait for Child processes, and `oadesktopentry` could end up with many zombie `sh` processes under it, which would persist until `opendeck` was restarted.
phyber
force-pushed
the
20260128-fix_child_zombies
branch
from
f877a28 to
14a6856
Compare
phyber
changed the title
Child processes as to not leave zombies
Author
|
Realised that the license of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where the plugin was leaving behind zombie
shprocesses after each button push as we weren't.wait()ing on the returnedChild.We now
forkand detach child processes to avoid zombieshprocesses gathering under theoadesktopentryprocess.This was tested by launching a variety of desktop apps, including both long running (terminals) and briefly running (opening links in an existing Firefox) processes.
This change introduces the
forkcrate as a dependency.