deps: use freedesktop-icons instead of tux-icons #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Problem I tried this plugin on my nixos desktop and while the app opening worked correctly, the icon for the app was not showing correctly. ### Solution using the freedesktop version makes it so we get standard handling of icons for desktop entry. By leveraging the standard, we get wider support out of the box (which means that the plugins works on nixos). We also can now select the preferred dimension for the icon, which tux-icons did not offer. This lead to some icons being pixelated since tux-icons returned the first match. I chose 256 as the resolution because it looked correct on my stream deck, but I'm happy to tweak this or even expose it as a setting down the line. ### Testing - Tested and working on my physical stream deck hooked to my nixos desktop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I tried this plugin on my nixos desktop and while the app opening worked correctly, the icon for the app was not showing correctly.
Solution
using the freedesktop version makes it so we get standard handling of icons for desktop entry. By leveraging the standard, we get wider support out of the box (which means that the plugins works on nixos).
We also can now select the preferred dimension for the icon, which tux-icons did not offer. This lead to some icons being pixelated since tux-icons returned the first match. I chose 256 as the size because it looked correct on my stream deck, but I'm happy to tweak this or even expose it as a setting down the line.
Testing
Tested and working on my physical stream deck hooked to my nixos desktop.