Update README: Remove SampleAssetManager reference (Fixes #121) #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
Hi @OpenAssetIO/maintainers, the GitHub Actions workflows are pending approval. Can someone please review and approve them so I can proceed? Thanks! |
feltech
requested changes
May 22, 2025
Member
feltech
left a comment
feltech
left a comment
There was a problem hiding this comment.
Thanks for this! Apologies for the delayed review. Text looks good, just a couple of style guideline nits.
UMMAN2005
force-pushed
the
fix-readme-sample-ref
branch
from
9de81e7 to
077da5a
Compare
Contributor
Author
|
Ready to merge :) |
Member
|
Ah, one last thing
You just need to GPG sign your commit. |
UMMAN2005
force-pushed
the
fix-readme-sample-ref
branch
3 times, most recently
from
8d01bb3 to
a509693
Compare
Fixes OpenAssetIO#121 Signed-off-by: Umman Mammadov <ummanmemmedov2005@gmail.com>
UMMAN2005
force-pushed
the
fix-readme-sample-ref
branch
from
a509693 to
edceff0
Compare
Contributor
Author
|
I added verified signature :) |
feltech
approved these changes
May 23, 2025
Member
|
All merged, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.