-
Notifications
You must be signed in to change notification settings - Fork 2
seantronsen/replace minio with versitygw #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
You'll probably want to open a PR on https://github.com/OpenCHAMI/openchami.org instead since that has the latest iteration of the tutorial. |
317a137 to
95e6de8
Compare
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
95e6de8 to
ca3b1df
Compare
synackd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things I noticed on first glance.
| s3cmd setacl s3://efi --acl-public | ||
| s3cmd setownership s3://efi BucketOwnerPreferred | ||
| aws s3api put-bucket-acl --bucket efi --acl public-read --endpoint-url http://localhost:7070 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be simpler to rely on one S3 tool instead of two. Are we able to do everything that we need with aws that we were doing with s3cmd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah aws can satisfy all the requirements presented in this tutorial, I can switch things over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to take me longer than I anticipated as I have to review the manuals for aws CLI. The options are much more verbose than the same for s3cmd. See below for an example translation:
translation for: s3cmd ls -Hr s3://boot-images | awk '{print $4}'
aws s3 ls --endpoint-url http://localhost:7070 --recursive --human-readable s3://boot-images | awk '{print "s3://boot-images/"
$5}'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, it might be simpler to, instead of replacing s3cmd, adding aws alongside it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say for now that this isn't a priority, more of a quality-of-life thing. As long as it works for the tutorial, we can update this subsequently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, it might be simpler to, instead of replacing
s3cmd, addingawsalongside it.
Noted. AFAIK, the current state satisfies this. Since the next goal is to translate this to the tutorial on the documentation site, should I open an additional issue over on that repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think time is better spent adding it there instead of here. 🙂
Noted. I'm not able to work on OpenCHAMI stuff again until the upcoming Monday, but I'll get a PR created for the main site then! |
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
92b33af to
097a18b
Compare
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
097a18b to
9450e2e
Compare
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
The primary purpose of this PR is to address #11 and switch from
miniotoversitygwas the former is terminating support for open-source. To this end, the existing openchami quadlet forversitygwwas introduced. Some additional updates were introduced and are listed below:nodes.yamlto use the new schema and silence deprecation errors withochami discover staticcorednsCorefileto address port conflicts withdnsmasqandaardvarkawsCLI to addresss3cmdXML schema incompatibilities forsetaclFixes #11
Type of Change
For more info, see Contributing Guidelines.