Skip to content

Conversation

@seantronsen
Copy link
Collaborator

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

The primary purpose of this PR is to address #11 and switch from minio to versitygw as the former is terminating support for open-source. To this end, the existing openchami quadlet for versitygw was introduced. Some additional updates were introduced and are listed below:

  • updates all dependency listings/media to reflect the current set of services
  • updates nodes.yaml to use the new schema and silence deprecation errors with ochami discover static
  • adds instructions for coredns Corefile to address port conflicts with dnsmasq and aardvark
  • adds aws CLI to address s3cmd XML schema incompatibilities for setacl
  • fixes a few typos
  • ensures all shell output blocks are up to date w.r.t the latest openchami releases at the time of writing

Fixes #11

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

@seantronsen seantronsen linked an issue Jan 14, 2026 that may be closed by this pull request
1 task
@davidallendj
Copy link
Contributor

You'll probably want to open a PR on https://github.com/OpenCHAMI/openchami.org instead since that has the latest iteration of the tutorial.

@seantronsen seantronsen force-pushed the seantronsen/replace-minio-with-versitygw branch from 317a137 to 95e6de8 Compare January 14, 2026 18:24
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen seantronsen force-pushed the seantronsen/replace-minio-with-versitygw branch from 95e6de8 to ca3b1df Compare January 14, 2026 18:26
Copy link
Contributor

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things I noticed on first glance.

Comment on lines -278 to +298
s3cmd setacl s3://efi --acl-public
s3cmd setownership s3://efi BucketOwnerPreferred
aws s3api put-bucket-acl --bucket efi --acl public-read --endpoint-url http://localhost:7070
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be simpler to rely on one S3 tool instead of two. Are we able to do everything that we need with aws that we were doing with s3cmd?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah aws can satisfy all the requirements presented in this tutorial, I can switch things over.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to take me longer than I anticipated as I have to review the manuals for aws CLI. The options are much more verbose than the same for s3cmd. See below for an example translation:

translation for: s3cmd ls -Hr s3://boot-images | awk '{print $4}'

aws s3 ls --endpoint-url http://localhost:7070 --recursive --human-readable s3://boot-images | awk '{print "s3://boot-images/"
$5}'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, it might be simpler to, instead of replacing s3cmd, adding aws alongside it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say for now that this isn't a priority, more of a quality-of-life thing. As long as it works for the tutorial, we can update this subsequently.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, it might be simpler to, instead of replacing s3cmd, adding aws alongside it.

Noted. AFAIK, the current state satisfies this. Since the next goal is to translate this to the tutorial on the documentation site, should I open an additional issue over on that repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think time is better spent adding it there instead of here. 🙂

@seantrons
Copy link

You'll probably want to open a PR on https://github.com/OpenCHAMI/openchami.org instead since that has the latest iteration of the tutorial.

Noted. I'm not able to work on OpenCHAMI stuff again until the upcoming Monday, but I'll get a PR created for the main site then!

Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen seantronsen force-pushed the seantronsen/replace-minio-with-versitygw branch from 92b33af to 097a18b Compare January 15, 2026 15:15
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen seantronsen force-pushed the seantronsen/replace-minio-with-versitygw branch from 097a18b to 9450e2e Compare January 15, 2026 15:18
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Replace minio with versitygw

5 participants