Refactor clean_loglogins script#671
Open
pmeulen wants to merge 4 commits into
Open
Conversation
Member
pmeulen
commented
May 12, 2026
pmeulen
commented
- Assign all Jina2 parameters to BASH variables and use from there
- Move magic constants to BASH variables
- Add --force option
- Add error handling fo all SQL queries
- Log when there is no data to delete
- Log when a mail is sent
- Log what database is used
- Assign all Jina2 parameters to BASH variables and use from there - Move magic constants to BASH variables - Add --force option - Add error handling fo all SQL queries - Log when there is no data to delete - Log when a mail is sent - Log what database is used
There was a problem hiding this comment.
Pull request overview
Refactors the clean_loglogins maintenance script template to centralize configuration in variables, improve logging, and add a --force override for the deletion safety check.
Changes:
- Refactored the script to use Bash variables for all Jinja2-provided values and “magic constants”.
- Added
--forceflag handling to bypass the MAX_DELETE_DAYS safeguard. - Added helper functions for logging and mailing, and expanded runtime logging (DB used, no-data cases, mail-sent).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+83
to
+85
| log_message "No logins found in log_logins" | ||
| send_mail "No logins found in log_logins" | ||
| exit |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.