Skip to content

Improve invite integration #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phavekes merged 5 commits into from
Oct 9, 2025
Merged

Improve invite integration #61

phavekes merged 5 commits into from
Oct 9, 2025

Conversation

@phavekes
Copy link
Member

@phavekes phavekes commented Oct 7, 2025

No description provided.

@phavekes phavekes requested a review from baszoetekouw October 7, 2025 09:58
@phavekes phavekes requested a review from crosmuller October 8, 2025 15:12
@crosmuller
Copy link
Contributor

crosmuller commented Oct 9, 2025 •
edited
Loading

  • docker compose --profile invite up -d geeft bij mij de error service "inviteserver" depends on undefined service "oidcng": invalid compose project, invite profile toevoegen aan de oidcng service verhelpt dit
  • invite profile staat nog niet beschreven in de core/README.md (ik vind het lastig te zeggen hoe de profiles zouden moeten staan omdat ik niet precies weet hoe de applicaties met elkaar samenhangen).
  • in de andere app containers wordt / gemount naar /config, hier wordt /invite gemount naar /config, zou best kunnen werken maar dat hangt af vaan de applicatie neem ik aan waar die zijn configuratie bestanden zoekt?

@phavekes
Copy link
Member Author

phavekes commented Oct 9, 2025 •
edited
Loading

  • docker compose --profile invite up -d geeft bij mij de error service "inviteserver" depends on undefined service "oidcng": invalid compose project, invite profile toevoegen aan de oidcng service verhelpt dit
  • invite profile staat nog niet beschreven in de core/README.md (ik vind het lastig te zeggen hoe de profiles zouden moeten staan omdat ik niet precies weet hoe de applicaties met elkaar samenhangen).

Fixed

@phavekes phavekes merged commit fe25b60 into main Oct 9, 2025
2 checks passed
@phavekes phavekes deleted the feature/invite branch October 9, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crosmuller crosmuller crosmuller approved these changes

@baszoetekouw baszoetekouw Awaiting requested review from baszoetekouw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phavekes @crosmuller