Update to include links in the 'to find identifiers' block#158
Update to include links in the 'to find identifiers' block#158timgdavies wants to merge 2 commits intolivefrom
Conversation
|
@timgdavies For companies house this looks like:
But companies house is available online. Is it the code or the data that's incorrect? Clicking around a bit more, it looks like a problem that exists for several of the UK lists. If it is a data problem, are you happy to merge this, and have the incorrect data reflected more visibly on the site for a bit? |
|
Ah. It is a data problem. Hmm - I think we should fix the data first on this one. I'll see if I can get a quick fix in for those - as it would be data bug-fix. |
|
I've just looked - and this affects quite a lot of lists - so don't merge this right now - and we'll need to schedule a bit more work on the data. |
|
@timgdavies Just to flag in case you didn't notice, that most recent commit conflicts with some of the changes on master. |
|
@Bjwebb do you think this PR is still relevant? |
Based on #152.
@Bjwebb If this passes tests, I think it would be good to do a quick deploy of - as I hadn't spotted quite how hidden the links to lists were before.