Back macro won't interfere with holding backspace deleting multiple characters #2495
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1583
Test case setup:
Edit TestGame's TestInterface.dmf and add a new macro to
macrolist:Backsay hiTest case:
asdf, then hold backspace for a few seconds.Byond:
xyz says: "hi"appears in output)OD Before PR:
fgets removed. Command does not happen.OD After PR:
The remaining disparities here (in bold) basically require a couple RT changes. Making these changes to RT and rebuilding bring the test case to full parity.
LineEditthat callsargs.Handle()inKeyBindDownunder different conditions - in this case, in backspace it would only be called when it actually removes character(s). Other controls would need similar treatment, for situations like writing on paper.UserInterfaceManager.OnUIKeyBindStateChangedwhere it can requireargs.Handledto also be true in order to return true.