Skip to content

Add verbose output and error reporting to watch task #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Add verbose output and error reporting to watch task #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c5faef
Initial plan
Copilot Dec 12, 2025
614d52f
Add verbose output to watcher task in all theme builders
Copilot Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Service/ThemeBuilder/HyvaThemes/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,19 @@
return false;
}

$io->info('Starting watch mode for Hyvä theme...');
$io->text("Watching directory: $tailwindPath");
$io->newLine();

try {
chdir($tailwindPath);
passthru('npm run watch');
$returnCode = 0;
passthru('npm run watch', $returnCode);

Check failure on line 235 in src/Service/ThemeBuilder/HyvaThemes/Builder.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/Service/ThemeBuilder/HyvaThemes/Builder.php#L235 

System program execution function passthru() detected with dynamic parameter

if ($returnCode !== 0) {
$io->error("Watch process exited with error code: $returnCode");
return false;
}
} catch (\Exception $e) {
$io->error('Failed to start watch mode: ' . $e->getMessage());
return false;
Expand Down
12 changes: 11 additions & 1 deletion src/Service/ThemeBuilder/MagentoStandard/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,18 @@
return false;
}

$io->info('Starting watch mode for Magento Standard theme...');
$io->text("Theme path: $themePath");
$io->newLine();

try {
passthru('node_modules/.bin/grunt watch');
$returnCode = 0;
passthru('node_modules/.bin/grunt watch', $returnCode);

Check failure on line 201 in src/Service/ThemeBuilder/MagentoStandard/Builder.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/Service/ThemeBuilder/MagentoStandard/Builder.php#L201 

System program execution function passthru() detected with dynamic parameter

if ($returnCode !== 0) {
$io->error("Watch process exited with error code: $returnCode");
return false;
}
} catch (\Exception $e) {
$io->error('Failed to start watch mode: ' . $e->getMessage());
return false;
Expand Down
12 changes: 11 additions & 1 deletion src/Service/ThemeBuilder/TailwindCSS/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,19 @@
return false;
}

$io->info('Starting watch mode for TailwindCSS theme...');
$io->text("Watching directory: $tailwindPath");
$io->newLine();

try {
chdir($tailwindPath);
passthru('npm run watch');
$returnCode = 0;
passthru('npm run watch', $returnCode);

Check failure on line 207 in src/Service/ThemeBuilder/TailwindCSS/Builder.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/Service/ThemeBuilder/TailwindCSS/Builder.php#L207 

System program execution function passthru() detected with dynamic parameter

if ($returnCode !== 0) {
$io->error("Watch process exited with error code: $returnCode");
return false;
}
} catch (\Exception $e) {
$io->error('Failed to start watch mode: ' . $e->getMessage());
return false;
Expand Down
Loading