Added verbose info logs to NonEquilibriumCyclingProtocol SetupUnit#104
Open
Added verbose info logs to NonEquilibriumCyclingProtocol SetupUnit#104
info logs to NonEquilibriumCyclingProtocol SetupUnit#104Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage ? 86.92%
=======================================
Files ? 11
Lines ? 1446
Branches ? 0
=======================================
Hits ? 1257
Misses ? 189
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Not urgent in any way; this is more of a nice to have, and it's opt-in based on log level. |
Contributor
|
Oh, this one totally fell through the cracks for me. I like the changes, but I may complement this even more with some more detailed explanation. This makes a great initial contribution to base further development. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a way to help debug performance of various pieces of the
NonEquilibriumCyclingProtocolSetupUnit, I added individualINFOlevel logging statements to its execution blocks.