Conversation
* Neutral protein mutation convergence test * Charge changing protein mutation convergence test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Using GUFE's JSON decoder * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Using forward-reverse utility function in all tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Custom exceptions for unsupported operations * Failure test for unsupported PRO transformation * Double charge expected fail test
Added protein mutation support for setup unit as well as testing and tutorial. All within the same nonequilibrium cycling protocol.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
Author
|
Just wanted to say that most of the changes here are pre-approved from #106 . They are squashed in a single commit so it should be fairly easy to tell which changes are unique to this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 86.86% 87.30% +0.44%
==========================================
Files 11 14 +3
Lines 1439 1552 +113
==========================================
+ Hits 1250 1355 +105
- Misses 189 197 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
approved these changes
Dec 20, 2025
Member
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
Only had a very brief look, but this seems good!
This was
linked to
issues
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes would provide the protein mutation capabilities to the current NonEquilibriumCycling protocol. This is thought as a feature branch, that way other changes would be merged into
protein-mutation-protocolfirst before this one gets merged intomain.