Skip to content

fix api break test#1844

Merged
atravitz merged 1 commit intomainfrom
fix/api-break-check
Feb 12, 2026
Merged

fix api break test#1844
atravitz merged 1 commit intomainfrom
fix/api-break-check

Conversation

@mikemhenry
Copy link
Contributor

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@mikemhenry mikemhenry requested a review from atravitz February 12, 2026 23:01
@github-actions
Copy link

🚨 API breaking changes detected! 🚨
View logs for this step

@mikemhenry
Copy link
Contributor Author

It works locally, I think b/c of the way we have this setup, it doesn't use the version of this file, but the version on main

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (ad07917) to head (edf88c7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
- Coverage   95.22%   92.98%   -2.25%     
==========================================
  Files         204      204              
  Lines       17623    17623              
==========================================
- Hits        16781    16386     -395     
- Misses        842     1237     +395     
Flag Coverage Δ
fast-tests 92.98% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz merged commit 89d1948 into main Feb 12, 2026
10 checks passed
@atravitz atravitz deleted the fix/api-break-check branch February 12, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants