fix(deps): update dependency vuetify to v4#349
Conversation
Deploying geodatalytics with
|
| Latest commit: |
94c36b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa4b1b97.geodatalytics.pages.dev |
| Branch Preview URL: | https://renovate-vuetify-4-x.geodatalytics.pages.dev |
4cd6577 to
1957426
Compare
|
@annehaley I've pushed some code changes to support syntax changes for this update. Can you look at https://renovate-vuetify-4-x.geodatalytics.pages.dev/ and verify that things look correct? |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
6419f55 to
14c36f7
Compare
|
The first thing I notice is the removal of the default text transform on In terms of the code changes, I'm concerned about the replacement of classes like I think it would be wise to ask @faiza-a for her opinion as well, since this upgrade introduces a lot of tiny spacing and sizing changes. |
I could restore this, just let me know what you prefer. Personally, I think it's nicer to not be shouted at by my buttons.
I'll investigate.
Vuetify 4 now uses cascade layers for all of its declarations (like However, the codebase here uses a mixture of utility classes, custom CSS, custom CSS with See my commit message:
So, we only have effective style differences in cases where there was previous a conflict between different types of styling. My commit was an attempt to only address conflicts, by moving conflicting things out of utility classes (which tended to be more piecemeal) and into the custom CSS (which seemed to be more authoritative).
Sure. In general, I find that if you want well-behaved (across screen sizes) and consistent-styled CSS, then less is more. Generally, having a few broadly scoped rules tends be more maintainable and effective than trying to control individual pixels everywhere. If it's possible to fix any new issues by removing or generalizing CSS, I think that's ideal. |
Can you give specific examples of where you see icon and scrollbar differences? |
|
The scrollbar I noticed is on the lefthand sidebar once a project is selected. I actually think this is just because the vertical padding on the As for the icons, they didn't load the first time but now I see them consistently. It may have just failed to fetch them on that first load? So disregard my comment about the material symbols icons. |
14c36f7 to
5afb8a8
Compare
|
The TypeScript improvements combined with the new Vuetify version have surfaced some type errors here. I'd appreciate any guidance for fixing them. |
Vuetify 3 utility classes used !important and won over component styles. Vuetify 4 replaced !important with CSS layers, so unlayered component styles now override them. Consolidate the utility class values into the component CSS rules and remove the now-ineffective utility classes from templates.
5afb8a8 to
94c36b2
Compare
I'm not seeing this on my screen size (or my attempts to resize). Could you provide a screenshot? The Cloudflare branch preview is nice for this. Alternatively, if you'd like to push any changes that make this work on your screen size, go ahead. |
This PR contains the following updates:
3.12.3→4.0.2Release Notes
vuetifyjs/vuetify (vuetify)
v4.0.2Compare Source
🚀 Features
🔧 Bug Fixes
next()deprecated in Vue Router v5 (#22643) (87c4129), closes #22632🧪 Labs
limitbehavior to cover overflow item (e580ebc), closes #22702 #22703v4.0.1Compare Source
🚀 Features
🔧 Bug Fixes
🧪 Labs
hide-browseshould hide divider as well (84f70ef)controlReffor internal<input />(36d3d3c)multiple(c93d2b7)v4.0.0Compare Source
v4.0.0 (Revisionist)
Welcome to the v4.0.0 release of Vuetify!
Supporting Vuetify
Vuetify is an open source MIT project that has been made possible due to the generous contributions by sponsors and backers. If your business depend on Vuetify, please consider joining sponsors and backers on various platforms to help support ongoing development and new features.
❗️ Important Links
💯 Release notes
🚀 Features
badgeprop +dot-sizefor VBadge (#22496) (cc9f417)menu-elevationprop (4605987)<img>(#22439) (71e01aa), closes #18860 #18907indent-detailsprop (#21265) (f483092), closes #16679multi-lineprop (#22212) (1371aba), closes #15996🔧 Bug Fixes
🔬 Code Refactoring
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.