Open
Conversation
Deploying geodatalytics with
|
| Latest commit: |
03671f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://378b3662.geodatalytics.pages.dev |
| Branch Preview URL: | https://demo-fixes.geodatalytics.pages.dev |
BryonLewis
approved these changes
Mar 19, 2026
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
a few questions, I don't think any are blockers and could be implemented/updated if required.
brianhelba
reviewed
Mar 20, 2026
| if project_id: | ||
| # Return queryset filtered by objects that are within these projects | ||
| return queryset.filter_by_projects(Project.objects.filter(id__in=ids)) | ||
| return queryset.filter_by_projects(Project.objects.filter(id=project_id)) |
Collaborator
There was a problem hiding this comment.
Should this be a .get or do we want to intentionally allow an non-existent project_id to be passed?
Collaborator
Author
There was a problem hiding this comment.
The filter_by_projects function accepts a Queryset of Projects, so we must use .filter instead of .get so that we send a queryset instead of a single object.
brianhelba
reviewed
Mar 20, 2026
brianhelba
requested changes
Mar 20, 2026
Collaborator
brianhelba
left a comment
brianhelba
left a comment
There was a problem hiding this comment.
1 question, 1 small code simplification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some miscellaneous behavior that I discovered when preparing my demo for the webinar:
GuardianFilterinaccess_control.py