security: disable uv cache in PR review workflow#159
Merged
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
approved these changes
Apr 8, 2026
Contributor
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean security hardening.
Linus's Three Questions:
- ✅ Solving a real problem? YES - Cache poisoning via prompt injection is a legitimate attack vector
- ✅ Simpler way? NO - This is already minimal
- ✅ What will it break? NOTHING - Only affects performance, security benefit > cost
Verdict: Worth merging. Focused change with proper justification.
Key Insight: Cache poisoning via prompt injection in privileged workflows is a real threat; disabling caching is the right trade-off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup-uvcaching in the privileged PR review workflowWhy
The cache hardening is worth landing independently so it can be reviewed and merged separately from the broader PR review trigger/checkout changes.
Testing
uv run --with pytest pytest tests/test_workflow_sync.pygit diff --checkThis PR was created by an AI assistant (OpenHands) on behalf of the user.
@enyst can click here to continue refining the PR