Skip to content

Fix premature conversation termination when LLM produces content (GPT-5 Codex and GLM 4.6) #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanmichelini wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix premature conversation termination when LLM produces content (GPT-5 Codex and GLM 4.6) #1304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c6f36a
Fix premature conversation termination when LLM produces content
juanmichelini Dec 3, 2025
b6e3767
Merge branch 'main' into fix-premature-conversation-termination-clean
enyst Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions openhands-sdk/openhands/sdk/agent/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,13 +271,6 @@ def step(
# Emit VLLM token ids if enabled
self._maybe_emit_vllm_tokens(llm_response, on_event)

# Finish conversation if LLM produced content (awaits user input)
# Continue if only reasoning without content (e.g., GPT-5 codex thinking)
if has_content:
logger.debug("LLM produced a message response - awaits user input")
state.execution_status = ConversationExecutionStatus.FINISHED
return

def _requires_user_confirmation(
self, state: ConversationState, action_events: list[ActionEvent]
) -> bool:
Expand Down
Loading