hi3520dv200: enable CONFIG_FB to fix hifb module load#2104
Merged
Conversation
The vendor hifb.ko ships in the hisilicon-osdrv-hi3520dv200 package and is insmod'd by load_hisilicon at boot, but on the running camera it fails to resolve every framebuffer-core symbol it imports: hifb: Unknown symbol unregister_framebuffer (err 0) hifb: Unknown symbol framebuffer_alloc (err 0) hifb: Unknown symbol fb_dealloc_cmap (err 0) hifb: Unknown symbol register_framebuffer (err 0) hifb: Unknown symbol fb_alloc_cmap (err 0) hifb: Unknown symbol fb_pan_display (err 0) hifb: Unknown symbol framebuffer_release (err 0) Root cause: the per-board defconfig had `# CONFIG_FB is not set`, so drivers/video/fbmem.c and fbcmap.c are not compiled and those exports never enter kallsyms. hifb is itself the FB hardware driver - it only needs the FB core API, no CONFIG_FB_* sub-driver. The closest working DVR sibling, hi3536cv100, enables exactly CONFIG_FB=y with every CONFIG_FB_* / CONFIG_FRAMEBUFFER_CONSOLE / CONFIG_LOGO left unset; we mirror that minimum. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# CONFIG_FB is not set→CONFIG_FB=yin the hi3520dv200 3.0.8 kernel defconfig so the vendorhifb.kocan resolveregister_framebuffer/framebuffer_alloc/fb_alloc_cmap/fb_pan_display/framebuffer_release/unregister_framebuffer/fb_dealloc_cmapat insmod time.CONFIG_FB=y(noCONFIG_FB_*sub-driver, noCONFIG_FRAMEBUFFER_CONSOLE) already used by the working DVR siblinghi3536cv100— hifb is itself the FB hardware driver and only consumes the core API.Symptom (live camera, pre-fix)
Test plan
build (hi3520dv200_lite)job succeedsuImage.hi3520dv200size stays under the 2048 KB budget (Makefile:102CHECK_SIZE)openipc-hi3520dv200.dlab.torturelabs.com:dmesgshows nohifb: Unknown symbol …lineslsmod | grep hifblists the module/dev/fb0exists🤖 Generated with Claude Code