ci: drop cv300 qemu-boot allow-failure (issue chain complete)#161
Merged
Conversation
Two upstream fixes unblock the cv300 qemu-boot row: - OpenIPC/firmware#2105: load_hisilicon now uses hi_osal.ko in both branches (was: cma_osal.ko, which the firmware never builds). - widgetii/qemu-hisilicon#101 / commit 42dea48a: hi3516cv300 machine model no longer appends `mmz=…` to bootargs, matching real V3 board u-boot env. The script now takes the hisi allocator branch as it always did on real hardware. Local QEMU boot with both fixes in place loads 31 HISI modules (vs 34 on real openipc-hi3516cv300.dlab.torturelabs.com hardware) and reaches the login prompt with no Oops/panic/BUG/Trace. Drop the allow-failure marker and gate on min_modules=20 (well below the observed 31, with margin for benign drift). Issue body of #2061 marked this CI hardcoding as the final cleanup step; this is it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two upstream fixes unblock the cv300 qemu-boot row:
Test plan
Local QEMU boot with both fixes in place:
```
$ ./run-qemu-cv300.sh fixed
.../uImage.hi3516cv300
.../rootfs.squashfs.hi3516cv300
===CI:HISI_MOD_COUNT===31===
===CI:LSMOD_BEGIN===
open_acodec open_adec open_aenc open_ai open_aio open_ao
open_base open_chnl open_h264e open_h265e open_hwrng open_isp
open_ive open_jpege open_mipi_rx open_osal open_pwm open_rc
open_rgn open_sensor_i2c open_sensor_spi open_sys open_sys_config open_vedu
open_venc open_vgs open_vi open_vpss open_wdt
hi3516cv300_vou hi_piris (vendor blobs from osdrv)
===CI:LSMOD_END===
Welcome to OpenIPC
openipc-hi3516cv300 login:
```
Drop `allow-failure: true`, gate on `min_modules: 20` (well below observed 31, with margin for benign drift).
Closes the CI-hardcoding cleanup item originally tracked in OpenIPC/firmware#2061.