Open
Conversation
maximthomas
reviewed
Feb 14, 2026
opendj-server-legacy/src/main/java/org/opends/server/backends/cassandra/Storage.java
Show resolved
Hide resolved
maximthomas
reviewed
Feb 14, 2026
opendj-server-legacy/src/main/java/org/opends/server/backends/cassandra/Storage.java
Outdated
Show resolved
Hide resolved
maximthomas
requested changes
Feb 14, 2026
5b932e1 to
4a0cc66
Compare
Issue with guava: google/guava#1881 Considering now Java 11 is minimum required runtime, we should migrate to caffeine 3.x
e3df171 to
57a4873
Compare
06eb604 to
eabd9fc
Compare
maximthomas
approved these changes
Feb 15, 2026
Contributor
maximthomas
left a comment
There was a problem hiding this comment.
Hi @prthakre ,
Looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering now Java 11 is minimum required runtime, we can safely migrate to caffeine 3.
https://guava.dev/releases/33.4.7-jre/api/docs/com/google/common/cache/CacheBuilder.html#prefer-caffeine-over-guava-s-caching-api-heading