Skip to content

Skip JAR permissions for unsigned builds #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonygermano merged 1 commit into from
Jul 14, 2025
Merged

Skip JAR permissions for unsigned builds #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions server/build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,22 +1051,6 @@

<taskdef resource="net/sf/antcontrib/antlib.xml" classpathref="classpath" />

<!-- modify jar manifests -->
<!-- don't modify bcprov, since it already has the manifest changes and is signed by BC -->
<echo message="[Thread Count: ${manifest_thread_count}] Modifying jar manifests to add Permissions: all-permissions; Codebase: *; Application-Name: Mirth Connect" />
<for param="jarFile" parallel="true" threadCount="${manifest_thread_count}">
<fileset dir="${setup.client.lib}" includes="**/*.jar" excludes="bcp*.jar,bcutil*.jar"/>
<fileset dir="${setup.extensions}" includes="**/*.jar" />
<sequential>
<apply executable="jar">
<arg value="umf" />
<arg line="custom_manifest.mf" />
<srcfile />
<fileset file="@{jarFile}"/>
</apply>
</sequential>
</for>


<if>
<equals arg1="${disableSigning}" arg2="true" />
Expand All @@ -1076,6 +1060,22 @@
</then>

<else>
<!-- modify jar manifests -->
<!-- don't modify bcprov, since it already has the manifest changes and is signed by BC -->
<echo message="[Thread Count: ${manifest_thread_count}] Modifying jar manifests to add Permissions: all-permissions; Codebase: *; Application-Name: Mirth Connect" />
<for param="jarFile" parallel="true" threadCount="${manifest_thread_count}">
<fileset dir="${setup.client.lib}" includes="**/*.jar" excludes="bcp*.jar,bcutil*.jar"/>
<fileset dir="${setup.extensions}" includes="**/*.jar" />
<sequential>
<apply executable="jar">
<arg value="umf" />
<arg line="custom_manifest.mf" />
<srcfile />
<fileset file="@{jarFile}"/>
</apply>
</sequential>
</for>

<property file="${keystore_property_file}" />
<property name="signingTsa" value="http://timestamp.digicert.com" />

Expand Down