Fix/garage door#3
Open
maxarndt wants to merge 3 commits into
Open
Conversation
Member
|
Danke Max! ich werde das auf v1dev übernehmen und vor dem nächsten Release (sollte in 1-2 Wochen soweit sein) nochmal testen. Liebe Grüße, Michael |
Author
|
Gerne doch @mgeramb! Der Changelog in der Readme ist nun aktuell und die Version ist auch angepasst. Besten Dank und Grüße, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix inverted open/close logic in DoorWindow channel
Hi @mgeramb, thanks for your great work! While testing the SmartHomeBridge application I ran into an issue with my garage door. I was only able to close the garage door but wasn't able to open it via HomeKit.
Below you can find a generated description of the two fixes I made in my branch.
Issue 1: Inverted
targetDoorStatefor GarageDoor after movement stopsIn
HomeKitDoorWindow::setMovement, thetargetDoorStatewas set to the wrong value once the door stopped moving. In HomeKit,0means open and1means close, so position100should map to0. As a result, the GarageDoor tile showed the opposite state after the movement finished.Issue 2: Inverted DPT_OpenClose value in
commandPositionIn
KnxChannelDoorWindow::commandPosition, the value sent onKO_OPEN_CLOSEwas flipped. DPT_OpenClose (DPT 1.009) defines0 = Openand1 = Close, but the code sentCloseon an open command andOpenon a close command. TheSendOpenandSendClosemodes were also triggering on the wrong position. After the fix, all three handling modes send the correct value. Verified with shutters and a garage door — both now move in the expected direction from HomeKit.All this was tested with my Hörmann garage door and the appropriate Hörmann KNX gateway.


I would appreciate if you can have a look at it!
Thanks,
Max