test(pykotor): regression coverage for JSON export progress and stream roots#238
Open
cursor[bot] wants to merge 3 commits into
Open
test(pykotor): regression coverage for JSON export progress and stream roots#238cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Co-authored-by: Boden <th3w1zard1@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
🔨 Build Validation Summary✅ Version Check: Passed Tool Builds
🎉 All builds validated successfully! This PR is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds focused unit and integration tests for
resource_jsoninstallation export: CI/automation progress logging vs interactive TTY updates, and discovery of stream assets underStreamSoundsandStreamWaves/StreamVoice(not onlyStreamMusic).Type of Change
Package(s) Affected
Changes Made
Libraries/PyKotor/tests/resource/test_resource_json_export_progress.pycovering_supports_live_progress,_ExportProgressReporter(zero-total guard, CI bucket logging, TTY\rpath), and an end-to-end export fixture that asserts all three stream folder types contribute resources and JSON outputs.Risky behavior now covered
CIorGITHUB_ACTIONSis set, live stderr\rprogress is disabled; percentage milestones must appear on the logger. A regression would silently break log aggregators and the existing CLI test expectations that match100.00%stream paths._iter_stream_resourceswalksstreammusic_path,streamsounds_path, andstreamvoice_path(K1StreamWaves/ K2StreamVoice). Missing a root would under-export voice/SFX without failing loudly.Test files added/updated
Libraries/PyKotor/tests/resource/test_resource_json_export_progress.pyWhy this reduces regression risk
_ExportProgressReporterso future refactors cannot drop structuredlogger.infomilestones in automation.test_json_commands.py, catching omissions if iterators or folder resolution changes.Testing
Note: Full
uv runworkspace sync was not available in this environment (resolution failed on optionalkotordiff); tests were run withPYTHONPATH=Libraries/PyKotor/srcand minimal PyPI deps (pytest,pytest-timeout,bioware-kaitai-formats,kaitaistruct,defusedxml,ply,loggerplus). CI should run the standard PyKotor pytest job.Checklist
Related Issues
Related to regression-test coverage automation for recent
resource_jsonexport changes.