test(cli): regression coverage for JSON export CI progress gating#256
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(cli): regression coverage for JSON export CI progress gating#256cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Boden <th3w1zard1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds focused unit tests for
_supports_live_progressinresource_json.pyso installation/directory JSON export always uses logger-based percentage updates whenCIorGITHUB_ACTIONSis set, even if stderr still reports as a TTY. This matches the fix inc7e573d1dand protects caplog-based tests and CI log aggregators from silent regressions.Type of Change
Package(s) Affected
Changes Made
Libraries/PyKotor/tests/cli/test_resource_json_progress.pywith six tests covering:CI/GITHUB_ACTIONStruthy variants, TTY streams, non-TTY streams, and streams withoutisatty.Testing
Test Results
Risky behavior now covered
_ExportProgressReportercould use carriage-return live updates on stderr; percentage milestones would bypasslogger.info, breaking assertions that rely on captured logs (e.g.test_export_installation_to_json_tree_logs_percentage_progress) and hiding export progress from centralized CI logs.Test files added/updated
Libraries/PyKotor/tests/cli/test_resource_json_progress.pyWhy this reduces regression risk
The behavior is environment-sensitive (TTY vs CI). Direct unit tests pin the contract: whenever automation sets
CIorGITHUB_ACTIONS, live TTY progress must be disabled regardless ofisatty(), while normal TTY sessions still get live updates when those variables are unset.Checklist
read_lintsclean)Related Issues
Related to automated regression-test coverage for recently merged JSON export behavior.
Fixes #
Closes #
Related to #