test(cli): regression cover JSON export progress (CI vs TTY)#267
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(cli): regression cover JSON export progress (CI vs TTY)#267cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Boden <th3w1zard1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds focused regression tests for
pykotor.tools.resource_jsonprogress reporting: whenCIorGITHUB_ACTIONSis set, progress must go throughlogger.infoinstead of live\rstderr updates, even if the stream reports as a TTY (matches the fix infix(json-export): log progress when automated; casefold stream path assert).Type of Change
Package(s) Affected
Changes Made
Libraries/PyKotor/tests/cli/test_resource_json_progress.pycovering_supports_live_progressand_ExportProgressReporterbehavior under automation env vars vs interactive TTY.Risky behavior now covered
to-json/ installation exports would again emit only carriage-return stderr updates, so log aggregators andcaplogwould miss percentage milestones.isatty() -> Truestill uses the logger path whenCIorGITHUB_ACTIONSis truthy.Test files added/updated
Libraries/PyKotor/tests/cli/test_resource_json_progress.py(new)Why these tests materially reduce regression risk
\rrendering without relying on a real TTY.Testing
Test Results
Checklist
Related Issues
Related to regression coverage for JSON installation export progress behavior.
Additional Notes
MagicMocklogger). No game binaries or AgentDecompile involvement (library-only JSON export helpers).