test(common): cover case-aware is_kotor_install_dir detection#310
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(common): cover case-aware is_kotor_install_dir detection#310cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Contributor
|
Message that will be displayed on users' first pull request |
Contributor
🔨 Build Validation Summary✅ Version Check: Passed Tool Builds
🎉 All builds validated successfully! This PR is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for KOTOR install directory detection after PR #151 switched
is_kotor_install_dirtoCaseAwarePathin three call sites.Risky behavior now covered
chitin.keypresent).chitin.keyfilename (e.g.CHITIN.KEY).Test files added/updated
Libraries/PyKotor/tests/common/test_is_kotor_install_dir.py(new, 18 parametrized tests acrosscli_utils,patching, anddiff.engine)Why this reduces regression risk
These helpers gate high-blast-radius flows (patching installs, diff against game roots). A regression in
CaseAwarePathintegration could silently treat valid installs as invalid on Linux/macOS mod layouts with case drift. The tests lock the intended behavior without requiring a full KOTOR installation fixture.Validation
18 passed (POSIX case tests skipped on Windows by design).