chore(resource): remove unused KeyBif and Folder containers#6
Open
th3w1zard1 wants to merge 1 commit into
Open
chore(resource): remove unused KeyBif and Folder containers#6th3w1zard1 wants to merge 1 commit into
th3w1zard1 wants to merge 1 commit into
Conversation
No callers remain after the Installation extract port; drop dead IResourceContainer implementations and CMake entries.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Removes the now-dead KeyBifResourceContainer and FolderResourceContainer implementations from the resource library, reflecting the completed migration to extract::Installation-based resolution across the codebase.
Changes:
- Delete
KeyBifResourceContainerimplementation and public header. - Delete
FolderResourceContainerimplementation and public header. - Remove the deleted headers/sources from
src/libs/resource/CMakeLists.txtand add a short plan doc for the cleanup.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/libs/resource/container/keybif.cpp |
Removes the unused KEY/BIF container implementation. |
src/libs/resource/container/folder.cpp |
Removes the unused filesystem-folder container implementation. |
src/libs/resource/CMakeLists.txt |
Drops the removed headers/sources from the resource library build. |
include/reone/resource/container/keybif.h |
Removes the unused public header for the KEY/BIF container. |
include/reone/resource/container/folder.h |
Removes the unused public header for the folder container. |
docs/plans/2026-05-30-remove-dead-container-classes-plan.md |
Documents the cleanup plan and verification checklist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove dead
KeyBifResourceContainerandFolderResourceContainerimplementations. All engine/dataminer/toolkit resolution now goes throughextract::Installation(PR #4/#5); these classes had zero remaining callers.Still retained:
ErfResourceContainer,RimResourceContainer,ExeResourceContainer,MemoryResourceContainer(e.g. save-load reads.savvia ERF).Test plan
run_menu_smoke.sh)Plan:
docs/plans/2026-05-30-remove-dead-container-classes-plan.md