Skip to content

Conversation

@IsmathBadsha
Copy link

@IsmathBadsha IsmathBadsha commented Dec 23, 2025

Added temporary debug logging and a network connectivity check to features.sh for build failure investigation.

@leochr leochr requested review from leochr and removed request for navaneethsnair1 December 23, 2025 17:57
@leochr
Copy link
Member

leochr commented Dec 23, 2025

@IsmathBadsha Thank you for the PR. Such debug options needs to be guarded by a flag (disabled by default) as we wouldn't want these commands to run by default. There is already a VERBOSE flag which could also be used to control the enablement of these commands. Feel free to make the changes. I can also discuss with my team in the new year to make those changes.

The PR should also target the vNext branch as main is used for production images. I updated the base branch above to vNext (don't worry about the extra commits, they are for readme files only, which are primarily maintained in the main branch).

PS: please request a review from the Liberty container team as we maintain the design and source for Liberty containers and we wouldn't want incompatible changes being merged.

@leochr leochr changed the base branch from main to vNext December 23, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants