Skip to content

fix(server/webdav): improve error handling for PROPFIND #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xrgzs wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(server/webdav): improve error handling for PROPFIND #2066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions server/webdav/webdav.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,6 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
status, err = h.handleUnlock(brw, r)
case "PROPFIND":
status, err = h.handlePropfind(brw, r)
// if there is a error for PROPFIND, we should be as an empty folder to the client
if err != nil {
status = http.StatusNotFound
}
case "PROPPATCH":
status, err = h.handleProppatch(brw, r)
}
Expand Down Expand Up @@ -662,7 +658,10 @@ func (h *Handler) handlePropfind(w http.ResponseWriter, r *http.Request) (status
if errs.IsNotFoundError(err) {
return http.StatusNotFound, err
}
return http.StatusMethodNotAllowed, err
// It's safer to return 500 Internal Server Error to
// prevent clients from deleting files when we fail to read the FS
// (timeout, IO error, backend storage disconnected, etc)
return http.StatusInternalServerError, err
}
depth := infiniteDepth
if hdr := r.Header.Get("Depth"); hdr != "" {
Expand Down