Conversation
Pass force=True to logging.basicConfig so the logging configuration (level and format) is applied even if logging was previously configured. This ensures the application's logging settings take effect before adjusting individual logger levels in the subsequent loop.
…ds for improved performance
Clean up and reformat conditionals and logging in ASRProcessor for readability: use consistent double quotes, wrap long conditional expressions in parentheses, condense simple checks to single lines, and format multi-line logger calls. No functional behavior changes intended — defaults and logic remain the same; changes are purely stylistic and improve maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the ASR (Automatic Speech Recognition) processing pipeline, logging configuration, and websocket server responsiveness. The main focus is on making the ASR model more adaptive to incoming audio sample rates, fine-tuning silence detection thresholds, and improving system responsiveness by reducing sleep intervals in async message processing.
ASR Processing Improvements:
stop_history_eou,stop_threshold_eou,stop_history, andstop_thresholdto balance between timely finalization and avoiding mid-sentence cuts.--asr-sample-rate-hz) is increased from 16kHz to 48kHz, supporting higher-fidelity audio.Logging Enhancements:
force=Trueto ensure that the logging setup overrides any existing configurations, providing more predictable logging behavior.Websocket Server Responsiveness: