Skip to content

[com1] Replace viscosity by consistency factor for Herschel-Bulkley rheology#1251

Closed
JuLa96 wants to merge 12 commits intomasterfrom
JL_ConsistencyFactorForHerschelAndBulkley
Closed

[com1] Replace viscosity by consistency factor for Herschel-Bulkley rheology#1251
JuLa96 wants to merge 12 commits intomasterfrom
JL_ConsistencyFactorForHerschelAndBulkley

Conversation

@JuLa96
Copy link
Contributor

@JuLa96 JuLa96 commented Mar 16, 2026

The current implementation of the Herschel-Bulkley rheological model assumes that the consistency factor K from the original formulation is equal to the bulk dynamic viscosity. This is not true, so the bulk dynamic viscosity is replaced by the consistency factor K.

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py
@JuLa96 JuLa96 added enhancement New feature or request DebrisFrame labels Mar 16, 2026
@JuLa96 JuLa96 requested review from PaulaSp3 and fso42 March 16, 2026 08:49
@qltysh
Copy link
Contributor

qltysh bot commented Mar 16, 2026

❌ 1 blocking issue (1 total)

Tool Category Rule Count
black Style Incorrect formatting, autoformat by running qlty fmt. 1

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

@qltysh
Copy link
Contributor

qltysh bot commented Mar 16, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@JuLa96 JuLa96 requested a review from PaulaSp3 March 16, 2026 16:16
JuLa96 added 10 commits March 16, 2026 18:33
Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Update docs due to changes of the Herschel-Bulkley formulation

Update docs due to changes of the Herschel-Bulkley formulation
Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Update docs due to changes of the Herschel-Bulkley formulation

Update docs due to changes of the Herschel-Bulkley formulation

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Update docs due to changes of the Herschel-Bulkley formulation

Update docs due to changes of the Herschel-Bulkley formulation
Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Update docs due to changes of the Herschel-Bulkley formulation

Update docs due to changes of the Herschel-Bulkley formulation

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Update docs due to changes of the Herschel-Bulkley formulation

Update docs due to changes of the Herschel-Bulkley formulation
Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Replace viscosity by consistency factor for Herschel-Bulkley rheology

Replace viscosity by consistency factor in checkCfg.py

Fix input consistency factor in avaframe/tests/test_DFAfunctionsCython.py

Update docs due to changes of the Herschel-Bulkley formulation

Update docs due to changes of the Herschel-Bulkley formulation
@JuLa96 JuLa96 closed this Mar 16, 2026
@JuLa96 JuLa96 deleted the JL_ConsistencyFactorForHerschelAndBulkley branch March 16, 2026 18:31
@JuLa96 JuLa96 restored the JL_ConsistencyFactorForHerschelAndBulkley branch March 16, 2026 18:32
@JuLa96 JuLa96 deleted the JL_ConsistencyFactorForHerschelAndBulkley branch March 16, 2026 18:36
@JuLa96
Copy link
Contributor Author

JuLa96 commented Mar 17, 2026

Outdated. A new PR will be created dealing with this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DebrisFrame enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants