[com1] Replace viscosity by consistency factor for Herschel-Bulkley rheology#1252
Open
[com1] Replace viscosity by consistency factor for Herschel-Bulkley rheology#1252
Conversation
Contributor
❌ 1 blocking issue (1 total)
@qltysh one-click actions:
|
Contributor
|
Coverage Impact This PR will not change total coverage. Modified Components (1)
🛟 Help
|
PaulaSp3
reviewed
Mar 17, 2026
The doc was updated due to changes in the formulation of the Herschel-Bulkley rheology. Co-authored-by: Paula Spannring <95042192+PaulaSp3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the Herschel-Bulkley rheological model assumes that the consistency factor K from the original formulation is equal to the bulk dynamic viscosity. This is not true, so the bulk dynamic viscosity is replaced by the consistency factor K.
See issue: OpenNHM/DebrisFrame#55