F #7675: option to configure FQDN for remote_addr#7677
Open
atodorov-storpool wants to merge 1 commit into
Open
F #7675: option to configure FQDN for remote_addr#7677atodorov-storpool wants to merge 1 commit into
atodorov-storpool wants to merge 1 commit into
Conversation
atodorov-storpool
force-pushed
the
patch-44
branch
2 times, most recently
from
e33e9b2 to
394a327
Compare
sk4zuzu
reviewed
May 20, 2026
| remote_ip = Resolv.getaddress(conf[:remote_addr]) | ||
| next unless remote_ip =~ Resolv::IPv4::Regex | ||
|
|
||
| OpenNebula.log_info "Resolved remote_addr #{conf[:remote_addr]} to #{remote_ip}" |
Contributor
There was a problem hiding this comment.
Shouldn't OpenNebula::DriverLogger.log_info be used here? 🤔
Contributor
Author
There was a problem hiding this comment.
yep, forgot that the logging was refactored somewhere between 6.x and 7.x
will force-push updated patch
| OpenNebula.log_info "Resolved remote_addr #{conf[:remote_addr]} to #{remote_ip}" | ||
| conf[:remote_addr] = remote_ip | ||
| rescue Resolv::ResolvError | ||
| OpenNebula.log_warning "Can't resolve remote_addr #{conf[:remote_addr]}. Skipping." |
Contributor
There was a problem hiding this comment.
Shouldn't OpenNebula::DriverLogger.log_warning be used here? 🤔
Contributor
Author
There was a problem hiding this comment.
yep, forgot that the logging was refactored somewhere between 6.x and 7.x
will force-push updated patch
Contributor
|
Maybe indicating inside OpenNebulaNetwork.conf (in comments) that using FQDN is now a possibility would help some users. 🤔 |
atodorov-storpool
force-pushed
the
patch-44
branch
from
394a327 to
820c154
Compare
So the resolver on the host will provide the IP address for the opennebula-gate service. This way, with DNS view or a line in /etc/hosts the tproxy service will pick the desired IP to connect to the opennebula-gate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This way the resolver on the host will provide the IP address for tproxy to communicate with the opennebula-gate service. So, with a DNS view or a line in /etc/hosts file on the host(s) the tproxy service will pick the desired IP to connect to the opennebula-gate endpoint.
Branches to which this PR applies