tls-gnutls.c: Do not check for errno after I/O operations#1507
Merged
michaelrsweet merged 1 commit intoOpenPrinting:masterfrom Mar 5, 2026
Merged
tls-gnutls.c: Do not check for errno after I/O operations#1507michaelrsweet merged 1 commit intoOpenPrinting:masterfrom
michaelrsweet merged 1 commit intoOpenPrinting:masterfrom
Conversation
Based on gnutls_record_send/recv man pages, we should use the return value of the functions as indicator what happened in the function and do not look into errno at all. Checking the errno value caused infinity loop in cupsd on busy servers if there were enough connection errors when cupsd wrote the response. The patch is provided by Paul Zirnik from SUSE - thank you for the patch! Fixes OpenPrinting#827
michaelrsweet
added
bug
michaelrsweet
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on gnutls_record_send/recv man pages, we should use the return value of the functions as indicator what happened in the function and do not look into errno at all.
Checking the errno value caused infinity loop in cupsd on busy servers if there were enough connection errors when cupsd wrote the response.
The patch is provided by Paul Zirnik from SUSE - thank you for the patch!
Fixes #827