Skip to content

Refactor type reflection#81

Merged
yhteoh merged 3 commits intov0.2devfrom
refactor_type_reflection
Sep 22, 2025
Merged

Refactor type reflection#81
yhteoh merged 3 commits intov0.2devfrom
refactor_type_reflection

Conversation

@yhteoh
Copy link
Collaborator

@yhteoh yhteoh commented Sep 22, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    refactor

  • What is the current behavior? (You can also link to an open issue here)

    • Analog layer not using TypeReflectBaseModel
    • Using Unions of pydantic models without discrimination
  • What is the new behavior (if this is a feature change)?

    • Analog layer uses TypeReflectBaseModel
    • Use of discriminated unions
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Minor, key no longer a valid argument in types for analog interface

  • Other information:

@yhteoh yhteoh mentioned this pull request Sep 22, 2025
7 tasks
@yhteoh yhteoh self-assigned this Sep 22, 2025
@yhteoh yhteoh added the refactor Code has been refactored label Sep 22, 2025
@yhteoh yhteoh marked this pull request as ready for review September 22, 2025 17:28
@yhteoh yhteoh merged commit ca174c1 into v0.2dev Sep 22, 2025
3 checks passed
@yhteoh yhteoh deleted the refactor_type_reflection branch September 22, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code has been refactored

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant