Remove restart(); add framework for reload() support#961
Merged
navi-desu merged 1 commit intoOpenRC:masterfrom Jan 7, 2026
Merged
Remove restart(); add framework for reload() support#961navi-desu merged 1 commit intoOpenRC:masterfrom
navi-desu merged 1 commit intoOpenRC:masterfrom
Conversation
Member
|
i think i'd rather print an error like |
Author
|
That's why I wrote "currently", I think? But yeah, please merge and change the ewarn message to whatever feels better to you, the message is just a placeholder. |
OpenRC will never call restart(), so scrap the definition in openrc-run.sh and s6.sh. reload() caused a weird error message when used without supervisor=s6, so add proper support for generic reload(), instantiated for s6, and with a better default error message for other backends - which can now add support for reload() down the line. Also clarify a comment, and add info messages on s6_reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenRC will never call restart(), so scrap the definition in
openrc-run.sh and s6.sh.
reload() caused a weird error message when used without
supervisor=s6, so add proper support for generic reload(), instantiated for s6, and with a better default error message for other backends - which can now add support for reload() down the line.
Also clarify a comment, and add info messages on s6_reload.