core: implement logic to enable live search progress logging for LMR#15315
Merged
MartinBourbier merged 1 commit intobam/lmr-search-progressfrom Mar 18, 2026
Merged
Conversation
MartinBourbier
force-pushed
the
mbr/core-lmr-search-progress
branch
11 times, most recently
from
a0cdf86 to
56f4c36
Compare
Khoyo
reviewed
Mar 2, 2026
MartinBourbier
force-pushed
the
mbr/core-lmr-search-progress
branch
7 times, most recently
from
ff98005 to
d688247
Compare
MartinBourbier
force-pushed
the
mbr/core-lmr-search-progress
branch
from
d688247 to
7622dcc
Compare
eckter
reviewed
Mar 4, 2026
Contributor
eckter
left a comment
eckter
left a comment
There was a problem hiding this comment.
I haven't tested it yet, but it does look like what I had in mind. I think we can wait for the editoast part to really test it out.
I'm not sure I understand the current behavior though: it logs progress in the queue, including one update with the final response, and then sends a different response identical to the one before this PR? That explains how it can work without editoast change. Is the plan to remove that final response?
MartinBourbier
force-pushed
the
mbr/core-lmr-search-progress
branch
3 times, most recently
from
f14441c to
57b5d70
Compare
MartinBourbier
force-pushed
the
mbr/core-lmr-search-progress
branch
from
ff74604 to
c8b069d
Compare
MartinBourbier
force-pushed
the
mbr/core-lmr-search-progress
branch
2 times, most recently
from
97e3143 to
a3b04e9
Compare
github-actions
Bot
added
area:front
Contributor
|
MartinBourbier
force-pushed
the
mbr/core-lmr-search-progress
branch
2 times, most recently
from
e90651c to
a3b04e9
Compare
github-actions
Bot
removed
area:front
MartinBourbier
force-pushed
the
mbr/core-lmr-search-progress
branch
2 times, most recently
from
6945137 to
938efdc
Compare
MartinBourbier
commented
Mar 18, 2026
Comment on lines
+94
to
+95
| val bestTravelTime = | ||
| (node.timeData.earliestReachableTime + node.remainingTimeEstimation).toULong() |
Contributor
Author
Contributor
There was a problem hiding this comment.
Looks correct, but I'm not an STDCM expert
(btw, you don't need a formal approval to merge into a branch that is neither dev nor staging)
Signed-off-by: Martin Bourbier <mbourbier28@gmail.com>
MartinBourbier
force-pushed
the
mbr/core-lmr-search-progress
branch
from
938efdc to
ecb66bc
Compare
Khoyo
approved these changes
Mar 18, 2026
MartinBourbier
merged commit c0f11f1
into
bam/lmr-search-progress
24 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15148
Warning
The CI will fail as long as the editoast part is not done