editoast: remove path_item_positions from SimulationSummary#15321
Merged
woshilapin merged 1 commit intodevfrom Feb 19, 2026
Merged
editoast: remove path_item_positions from SimulationSummary#15321woshilapin merged 1 commit intodevfrom
path_item_positions from SimulationSummary#15321woshilapin merged 1 commit intodevfrom
Conversation
github-actions
Bot
added
area:front
Contributor
|
The `path_item_positions` is relative to a pathfinding, and not the simulation. It is already present inside the pathfinding response, so it is still available if needed. Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
woshilapin
force-pushed
the
wsl/zpxpupvvmwtt
branch
from
5830968 to
3e541ed
Compare
younesschrifi
approved these changes
Feb 19, 2026
Contributor
|
This field was added for the data team : #13087 |
SharglutDev
approved these changes
Feb 19, 2026
Contributor
Author
Data team is a consumer of the API and will adapt to the API (it actually already has in this case). I don’t believe it should drive how the API are designed (especially is the design feels a bit off). Not to say we should never take into account potential consumer use cases, but it’s only an input to help design a better API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
path_item_positionsis relative to a pathfinding, and not the simulation. It is already present inside the pathfinding response, so it is still available if needed.ℹ️ The field
path_item_positionswas not used in thefront(the pathfinding one is used instead).