Remove unused streaming response type from embeddings endpoint #123
+0
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penRouterTeam#98) The embeddings endpoint had a text/event-stream response type defined in the OpenAPI spec, but the spec itself noted: "Not used for embeddings - embeddings do not support streaming." This unused response type caused Speakeasy to generate: type CreateEmbeddingsResponse = CreateEmbeddingsResponseBody | string; Which forces developers to write unnecessary type guards. After regenerating with Speakeasy, the type will be: type CreateEmbeddingsResponse = CreateEmbeddingsResponseBody; Allowing direct access to response.data[0].embedding without checking if the response is a string first. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #98
The embeddings endpoint has a
text/event-streamresponse type in the OpenAPI spec, but the spec itself says:This unused response type causes Speakeasy to generate:
Which forces developers to write unnecessary type guards:
Changes
Removed the unused
text/event-streamresponse from.speakeasy/in.openapi.yaml.After Regeneration
After regenerating with Speakeasy, the type will be:
Allowing clean access:
response.data[0].embeddingNote
This PR only updates the OpenAPI spec. The maintainers will need to regenerate with Speakeasy to update the TypeScript types.
🤖 Generated with Claude Code