Skip to content

Fix sip instance in REGISTER reply#3886

Open
dsandras wants to merge 1 commit intoOpenSIPS:3.6from
dsandras:ds-fix-sip-instance
Open

Fix sip instance in REGISTER reply#3886
dsandras wants to merge 1 commit intoOpenSIPS:3.6from
dsandras:ds-fix-sip-instance

Conversation

@dsandras
Copy link
Copy Markdown
Contributor

@dsandras dsandras commented May 5, 2026

The SIP Instance of the 200 OK response is not correctly formatted.

It should be surrounded by angle brackets following section 4.1 from RFC
5626:

  [RFC3840] defines equality rules for callee capabilities parameters,
  and according to that specification, the "sip.instance" media feature
  tag will be compared by case- sensitive string comparison.  This means
  that the URN will be encapsulated by angle brackets ("<" and ">") when
  it is placed within the quoted string value of the "+sip.instance"
  Contact header field parameter.

Summary

Details

Solution

Compatibility

Closing issues

@dsandras dsandras marked this pull request as draft May 5, 2026 08:43
@dsandras dsandras changed the base branch from master to 3.6 May 5, 2026 08:44
@dsandras dsandras marked this pull request as ready for review May 5, 2026 08:45
@dsandras
Copy link
Copy Markdown
Contributor Author

dsandras commented May 5, 2026

@liviuchircu @bogdan-iancu Hi!

Maybe one of you could check this one and consider it to be included? Thanks a lot.

Damien

@dsandras dsandras changed the title Ds fix sip instance Fix sip instance in REGISTER reply May 5, 2026
@dsandras dsandras force-pushed the ds-fix-sip-instance branch from 1dceb26 to b0c3005 Compare May 5, 2026 12:01
It should be surrounded by angle brackets following section 4.1 from RFC
5626:

  [RFC3840] defines equality rules for callee capabilities parameters,
  and according to that specification, the "sip.instance" media feature
  tag will be compared by case- sensitive string comparison.  This means
  that the URN will be encapsulated by angle brackets ("<" and ">") when
  it is placed within the quoted string value of the "+sip.instance"
  Contact header field parameter.
@dsandras dsandras force-pushed the ds-fix-sip-instance branch from b0c3005 to 8bc3d01 Compare May 5, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant