fix: upgrade opensecret SDK to 0.2.9 for streaming tool call passthrough#17
Merged
AnthonyRonning merged 1 commit intomasterfrom Feb 21, 2026
Merged
Conversation
Upgrades the opensecret crate from 0.2.8 to 0.2.9 which makes ChatCompletionChunk a transparent serde_json::Value wrapper. This fixes streaming deserialization failures when LLMs send null fields in subsequent tool_call delta chunks (e.g. multi-tool streaming with GLM-5). Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Streaming chat completions with multiple tool calls fail with:
This happens because the OpenAI streaming spec sends
nullforid,type, andfunction.namein subsequent tool_call delta chunks. The SDK (0.2.8) had these as requiredStringfields.Fix
Upgrades
opensecretfrom 0.2.8 to 0.2.9 (SDK PR), which makesChatCompletionChunka transparentserde_json::Valuewrapper for full JSON passthrough.Testing
Verified against
enclave.secretgpt.aiwithglm-5:Summary by CodeRabbit