Skip to content

Fix version, maybe?#89

Open
juliakreger wants to merge 1 commit intoOpenStackweb:masterfrom
juliakreger:fix-version
Open

Fix version, maybe?#89
juliakreger wants to merge 1 commit intoOpenStackweb:masterfrom
juliakreger:fix-version

Conversation

@juliakreger
Copy link
Copy Markdown
Collaborator

@juliakreger juliakreger commented May 5, 2026

Summary by CodeRabbit

  • Chores
    • Updated default release version reference to 35.0.0.

Signed-off-by: Julia Kreger <juliaashleykreger@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 81aceca3-c264-40d4-8c36-f4bcbdd16cb1

📥 Commits

Reviewing files that changed from the base of the PR and between b8d8812 and 19d0625.

📒 Files selected for processing (1)
  • gatsby-node.js

📝 Walkthrough

Walkthrough

The PR updates the fallback latest-release data in gatsby-node.js from version 34.0.0 to 35.0.0, including the corresponding release notes URL and log message. A minor formatting adjustment is also applied.

Changes

Fallback Release Version Bump

Layer / File(s) Summary
Fallback Data & Logging
gatsby-node.js
Fallback version bumped from 34.0.0 to 35.0.0; release notes URL updated to unreleased 35-0-0 path; fallback log message updated accordingly; minor formatting tweak applied.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • cardoe

Poem

🐰 A version hops forward, from 34 to 35,
The fallback now fresher, the code stays alive,
Release notes updated with unreleased cheer,
A hop toward tomorrow—new year drawing near!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix version, maybe?' is vague and uncertain. While it mentions 'version', which relates to the version bump in gatsby-node.js, the phrasing is ambiguous and lacks specificity about what version is being fixed or why. Use a more descriptive title that clearly states the version change, such as 'Update default release series from 34.0.0 to 35.0.0' or 'Bump fallback release version to 35.0.0'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread gatsby-node.js
version: '34.0.0',
releaseNotesUrl: 'https://docs.openstack.org/releasenotes/ironic/latest.html#relnotes-34-0-0',
version: '35.0.0',
releaseNotesUrl: 'https://docs.openstack.org/releasenotes/ironic/unreleased.html#relnotes-35-0-0',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
releaseNotesUrl: 'https://docs.openstack.org/releasenotes/ironic/unreleased.html#relnotes-35-0-0',
releaseNotesUrl: 'https://docs.openstack.org/releasenotes/ironic/2026.1.html#relnotes-35-0-0-stable-2026-1',

Gives prettier notes.

Comment thread gatsby-node.js
releaseNotesUrl: 'https://docs.openstack.org/releasenotes/ironic/unreleased.html#relnotes-35-0-0',
publishedAt: null,
htmlUrl: 'https://docs.openstack.org/releasenotes/ironic/',
releaseSeries: 'fallback',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
releaseSeries: 'fallback',
releaseSeries: 'unreleased',

Is that maybe we need to have it auto-update?

@elfosardo
Copy link
Copy Markdown
Contributor

this not working?
2f22570

@cardoe
Copy link
Copy Markdown

cardoe commented May 6, 2026

this not working?

2f22570

It's reporting 34.0.0 on https://ironicbaremetal.org so no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants