Skip to content

fix(oauth2): allow HTTP origins and fix trailing-slash mismatch for l…#128

Open
mulldug wants to merge 1 commit intomainfrom
fix/idp-local-dev-origin-and-ssl
Open

fix(oauth2): allow HTTP origins and fix trailing-slash mismatch for l…#128
mulldug wants to merge 1 commit intomainfrom
fix/idp-local-dev-origin-and-ssl

Conversation

@mulldug
Copy link
Copy Markdown
Collaborator

@mulldug mulldug commented May 7, 2026

…ocal dev

  • Strip trailing slash from normalizeUrl() results in isOriginAllowed() so origins with/without trailing slash match registered values
  • Conditionally skip HTTPS scheme enforcement when SSL.Enable is false, allowing HTTP clients in local dev
  • Fix SSL.Enable config key lookup (server.SSL_Enable → server.ssl_enable) to match the key name defined in config/server.php
  • Use getSchemeAndHttpHost() instead of hardcoded https:// prefix so the IDP base URL reflects the actual request scheme
  • Add fastcgi_buffers directives to nginx config to prevent buffer overflow

…ocal dev

- Strip trailing slash from normalizeUrl() results in isOriginAllowed() so origins with/without trailing slash match registered values
- Conditionally skip HTTPS scheme enforcement when SSL.Enable is false, allowing HTTP clients in local dev
- Fix SSL.Enable config key lookup (server.SSL_Enable → server.ssl_enable) to match the key name defined in config/server.php
- Use getSchemeAndHttpHost() instead of hardcoded https:// prefix so the IDP base URL reflects the actual request scheme
- Add fastcgi_buffers directives to nginx config to prevent buffer overflow
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@mulldug has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 52 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aeb2988f-cf34-4744-93d7-78652cc78c01

📥 Commits

Reviewing files that changed from the base of the PR and between db9f777 and 4fccb8e.

📒 Files selected for processing (4)
  • app/Models/OAuth2/Client.php
  • app/Services/Utils/ServerConfigurationService.php
  • config/server.php
  • docker-compose/nginx/idp.conf
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/idp-local-dev-origin-and-ssl

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-128/

This page is automatically updated on each push to this PR.

Comment thread config/server.php
return array
(
'ssl_enabled' => env('SSL_ENABLED', false),
'ssl_enable' => env('SSL_ENABLED', false),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is duping "server.ssl_enabled"
please use old key

@smarcet smarcet requested a review from romanetar May 8, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants