Conversation
wvpm
force-pushed
the
refactor_province_buildings
branch
2 times, most recently
from
07b5473 to
e5f8c81
Compare
wvpm
force-pushed
the
refactor_province_buildings
branch
from
e5f8c81 to
c9a437f
Compare
Spartan322
reviewed
Feb 14, 2026
Spartan322
reviewed
Feb 14, 2026
Spartan322
reviewed
Feb 14, 2026
wvpm
force-pushed
the
refactor_province_buildings
branch
from
6d97d9b to
e49fd41
Compare
wvpm
force-pushed
the
refactor_province_buildings
branch
from
d637c96 to
b1b8bf8
Compare
Spartan322
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use typed indices to simplify the code.
Use infrastructure building type for infrastructure map mode instead of relying on building name "railroad".
I confirmed Victoria 2 works this way by swapping the types of fort and railroad.
Also adds hashing support to TypedIndices.