Merged
Conversation
wvpm
commented
Feb 24, 2026
wvpm
force-pushed
the
refactor_pop_reference_wrapper
branch
from
2d5ad79 to
12924c9
Compare
Spartan322
reviewed
Feb 24, 2026
Spartan322
reviewed
Feb 24, 2026
wvpm
force-pushed
the
refactor_pop_reference_wrapper
branch
from
c48f633 to
94fd9bf
Compare
Spartan322
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pop always has a location. Pops must be movable, thus storing
ProvinceInstance&isn't an option.std::reference_wrapper<ProvinceInstance>keeps pops movable whilst avoiding redundant null checks.Also adds support for
std::reference_wrapper<ProvinceInstance> PROPERTY(location);It generates
ProvinceInstance const& get_location() const