Skip to content

fix: Sidebar-Counter für Wiedervorlagen reaktivieren#253

Open
Avatarsia wants to merge 1 commit into
OpenXE-org:masterfrom
Avatarsia:fix/250-wiedervorlage-sidebar-counter
Open

fix: Sidebar-Counter für Wiedervorlagen reaktivieren#253
Avatarsia wants to merge 1 commit into
OpenXE-org:masterfrom
Avatarsia:fix/250-wiedervorlage-sidebar-counter

Conversation

@Avatarsia
Copy link
Copy Markdown
Contributor

Summary

  • Reactivates the sidebar counter for overdue Wiedervorlagen (resubmissions/reminders)
  • The SQL query, permission checks (wiedervorlage:list), project rights filter, and badge rendering were already fully functional — only the menu entry in $possibleUserItems was commented out
  • Single 4-line change in www/eproosystem.php: remove /* and */ around the 'Wiedervorlage' array entry

Fixes #250

Test plan

  • Sidebar shows Wiedervorlage icon with badge counter
  • Counter shows only overdue Wiedervorlagen assigned to the logged-in user
  • Counter updates when Wiedervorlagen are completed or new ones become overdue
  • Entry only appears for users with wiedervorlage:list permission
  • Click navigates to index.php?module=wiedervorlage&action=list

🤖 Generated with Claude Code

Avatarsia pushed a commit to Avatarsia/OpenXE that referenced this pull request Apr 9, 2026
All four are single-file Avatarsia-authored bug fixes that are
also open upstream PRs on openxe-org:

- fix/250-wiedervorlage-sidebar-counter (PR OpenXE-org#253)
  www/eproosystem.php +2/-2: reactivate Wiedervorlagen counter

- fix/dateien-stichwoerter-245 (PR OpenXE-org#246)
  classes/Modules/Api/Controller/Version1/FileController.php +2/-2:
  fix variable scoping in POST /v1/dateien stichwoerter

- fix/versandpakete-247 (PR OpenXE-org#248)
  classes/Modules/Api/Controller/Version1/TrackingNumberController.php +25:
  write tracking numbers into the versandpakete table so the UI
  shows them

- fix/player-custom-module-support (PR OpenXE-org#256)
  phpwf/class.player.php +12/-2: support _custom.php extension
  files for page controllers, analogous to class.erpapi_custom.php

Each branch is based on an older origin/master snapshot, but
since origin/master is strictly behind upstream/master (zero
divergent commits), git merges only the new commits during
integration without re-applying the upstream drift.
@Avatarsia Avatarsia force-pushed the fix/250-wiedervorlage-sidebar-counter branch from a079cfc to 6cd7952 Compare May 7, 2026 20:18
@Avatarsia
Copy link
Copy Markdown
Contributor Author

Force-Push-Hinweis: Branch wurde direkt auf upstream/master rebased, sodass der Diff jetzt nur noch den eigentlichen Fix zeigt — ohne die ~150 Fork-internen Commits, die vorher mitliefen. Code-Endstand byte-identisch, nur die Commit-SHAs sind neu.

Bestehende Inline-Kommentare auf alten SHAs erscheinen jetzt als „outdated" — gerne nochmal kommentieren auf den neuen Commits, falls noch was offen ist.

Avatarsia pushed a commit to Avatarsia/OpenXE that referenced this pull request May 20, 2026
All four are single-file Avatarsia-authored bug fixes that are
also open upstream PRs on openxe-org:

- fix/250-wiedervorlage-sidebar-counter (PR OpenXE-org#253)
  www/eproosystem.php +2/-2: reactivate Wiedervorlagen counter

- fix/dateien-stichwoerter-245 (PR OpenXE-org#246)
  classes/Modules/Api/Controller/Version1/FileController.php +2/-2:
  fix variable scoping in POST /v1/dateien stichwoerter

- fix/versandpakete-247 (PR OpenXE-org#248)
  classes/Modules/Api/Controller/Version1/TrackingNumberController.php +25:
  write tracking numbers into the versandpakete table so the UI
  shows them

- fix/player-custom-module-support (PR OpenXE-org#256)
  phpwf/class.player.php +12/-2: support _custom.php extension
  files for page controllers, analogous to class.erpapi_custom.php

Each branch is based on an older origin/master snapshot, but
since origin/master is strictly behind upstream/master (zero
divergent commits), git merges only the new commits during
integration without re-applying the upstream drift.
Uncomment the Wiedervorlage menu item in the sidebar navigation.
The SQL query, permission checks, project rights filter, and badge
rendering were already functional - only the menu entry was disabled.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Avatarsia Avatarsia force-pushed the fix/250-wiedervorlage-sidebar-counter branch from 6cd7952 to 231e7bb Compare May 20, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Sidebar-Counter für überfällige Wiedervorlagen reaktivieren

1 participant