add multisig v3 preset#501
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| Signer_assertThresholdMet(finalState.validCount); | ||
|
|
||
| _coinNonce = evolveNonce(_counter, _coinNonce); | ||
| const contractRecipient = right<ZswapCoinPublicKey, ContractAddress>(kernel.self()); |
There was a problem hiding this comment.
Should this be sent to a custom address? (TBD)
There was a problem hiding this comment.
Yes, custom address for the user, not sending to this same contract
There was a problem hiding this comment.
(adapt burn function to be equivalent as well)
There was a problem hiding this comment.
(adapt burn function to be equivalent as well)
The backend infra/operator has the coin info for tokens minted so they can burn UTXOs not held by the contract; therefore, I don't see anything that needs to change with burn. LMK if I'm missing something
| Signer_assertThresholdMet(finalState.validCount); | ||
|
|
||
| _coinNonce = evolveNonce(_counter, _coinNonce); | ||
| const contractRecipient = right<ZswapCoinPublicKey, ContractAddress>(kernel.self()); |
There was a problem hiding this comment.
Yes, custom address for the user, not sending to this same contract
| Signer_assertThresholdMet(finalState.validCount); | ||
|
|
||
| _coinNonce = evolveNonce(_counter, _coinNonce); | ||
| const contractRecipient = right<ZswapCoinPublicKey, ContractAddress>(kernel.self()); |
There was a problem hiding this comment.
(adapt burn function to be equivalent as well)
2 participants
Types of changes
What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an
xin the boxes that applyFixes #???