Skip to content

Remove witnesses from dist#520

Closed
andrew-fleming wants to merge 2 commits into
OpenZeppelin:mainfrom
andrew-fleming:remove-witnesses-from-dist
Closed

Remove witnesses from dist#520
andrew-fleming wants to merge 2 commits into
OpenZeppelin:mainfrom
andrew-fleming:remove-witnesses-from-dist

Conversation

@andrew-fleming
Copy link
Copy Markdown
Contributor

@andrew-fleming andrew-fleming commented May 21, 2026

(if releasing without compact-tools dep)

Summary by CodeRabbit

  • Chores
    • Optimized the build pipeline to remove unused witness directories after compilation, resulting in cleaner distribution artifacts.

Review Change Stack

@andrew-fleming andrew-fleming requested review from a team as code owners May 21, 2026 06:19
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d54f08d1-975f-44eb-bbd3-ec863c8eaf93

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The build pipeline in CompactBuilder adds a witness directory cleanup step after TypeScript compilation and before copying distribution files. Step numbering comments are updated to reflect this new intermediate step in the build sequence.

Changes

Build Pipeline Witness Directory Cleanup

Layer / File(s) Summary
CompactBuilder witness cleanup and step renumbering
packages/compact/src/Builder.ts
A find command removes dist/**/witnesses directories after TypeScript compilation. Subsequent step numbering comments shift from "Step 3" → "Step 4" and "Step 4" → "Step 5" to reflect the new intermediate step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A builder cleans its witness stand,
Removes the secrets, all so grand,
Step numbers shuffle, left then right—
The pipeline flows, pristine and bright! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove witnesses from dist' directly and specifically describes the main change: removing witnesses directories from the dist folder after TypeScript compilation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@andrew-fleming
Copy link
Copy Markdown
Contributor Author

Superseded by #523 (which includes the removal here OpenZeppelin/compact-tools#91)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants