Merged
Conversation
…ker as JSON messages. Check README.md for details.
markdueck1
reviewed
Mar 19, 2026
| # get mqtt config from config file. | ||
| if (NMISNG::Util::existFile(dir=>'conf',name=>'mqttevent')) { | ||
| # loadtable falls back to conf-default if conf doesn't have the file | ||
| my $mqttConfig = NMISNG::Util::loadTable(dir=>'conf',name=>'mqttevent'); |
Contributor
There was a problem hiding this comment.
This isn't handling the error condition (the file may exist but not be valid). The other submission you made is. It should log the error and return early.
markdueck1
reviewed
Mar 19, 2026
| if (NMISNG::Util::existFile(dir=>'conf',name=>'mqttevent')) { | ||
| # loadtable falls back to conf-default if conf doesn't have the file | ||
| my $mqttConfig = NMISNG::Util::loadTable(dir=>'conf',name=>'mqttevent'); | ||
| $topic = $mqttConfig->{mqtt}{topic}; |
Contributor
There was a problem hiding this comment.
These are all assuming the {mqtt} entry exists
markdueck1
requested changes
Mar 19, 2026
Contributor
markdueck1
left a comment
markdueck1
left a comment
There was a problem hiding this comment.
The error handling on the table load needs to be fixed
…s to the MQTT publish
markdueck1
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team,
I have added the nmis-mqtt-event plugin to the contrib directory for your consideration.
Cheers
Keith