fix(marker-manager): prevent invalid array splicing and improve marker cleanup safety

[promonteiro]

The issue:

1. If the markerId was not found in the array, findIndex returns -1.
2. The code then executes markerArr.splice(-1, 1).
3. In JavaScript/TypeScript, passing a negative index to .splice() means "start from the end of the array."

Result: If the specific marker wasn't found, the code would accidentally delete the last marker in the array instead of doing nothing.

The Solution:

1. It stores the result of the search in a variable (idx).
2. It explicitly checks if idx is not equal to -1 (meaning the item actually exists).
3. It only attempts to delete (splice) the item if it was found.

Summary: This PR prevents the accidental removal of the last map marker when trying to clean up a marker ID that no longer exists in the array.

[gnbm]

Hello @promonteiro 👋
Thanks for your Pull Request. It looks like this may be your first contribution to an OutSystems Open Source project. Before we look into your contribution, we need you to accept the 📝 OutSystems Contributors License Agreement.
After you read and accept the terms of the agreement, reply to this message saying I read, understood and accept the OutSystems CLA.

After this step, we'll review your Pull Request and provide any feedback if needed.
Thank you and feel free to keep contributing! 🚀

[promonteiro]

I read, understood and accept the OutSystems CLA. Sent from Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Gonçalo M. ***@***.***> Sent: Monday, January 5, 2026 10:13:05 PM To: OutSystems/outsystems-maps ***@***.***> Cc: MONTEIRO Ricardo Oliveira ***@***.***>; Mention ***@***.***> Subject: Re: [OutSystems/outsystems-maps] fix(marker-manager): prevent invalid array splicing and improve marker cleanup safety (PR #217) You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> [https://avatars.githubusercontent.com/u/29493222?s=20&v=4]gnbm left a comment (OutSystems/outsystems-maps#217)<#217 (comment)> Hello @promonteiro<https://github.com/promonteiro> 👋 Thanks for your Pull Request. It looks like this may be your first contribution to an OutSystems Open Source project. Before we look into your contribution, we need you to accept the 📝 OutSystems Contributors License Agreement<https://outsystems-public-dl.s3-eu-west-1.amazonaws.com/opensource/cla/OutSystems-Contributor-License-Agreement-2020-03-23.pdf>. After you read and accept the terms of the agreement, reply to this message saying I read, understood and accept the OutSystems CLA. After this step, we'll review your Pull Request and provide any feedback if needed. Thank you and feel free to keep contributing! 🚀 — Reply to this email directly, view it on GitHub<#217 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BN5LJN7T3MSDMD6CHBK5BYT4FLOXDAVCNFSM6AAAAACQYLQZ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJSGI3DKMZWGE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[promonteiro]

I read, understood and accept the OutSystems CLA.

…

________________________________ From: MONTEIRO Ricardo Oliveira ***@***.***> Sent: Monday, January 5, 2026 10:31:04 PM To: OutSystems/outsystems-maps ***@***.***>; OutSystems/outsystems-maps ***@***.***> Cc: Mention ***@***.***> Subject: Re: [OutSystems/outsystems-maps] fix(marker-manager): prevent invalid array splicing and improve marker cleanup safety (PR #217) I read, understood and accept the OutSystems CLA. Sent from Outlook for iOS<https://aka.ms/o0ukef>

________________________________ From: Gonçalo M. ***@***.***> Sent: Monday, January 5, 2026 10:13:05 PM To: OutSystems/outsystems-maps ***@***.***> Cc: MONTEIRO Ricardo Oliveira ***@***.***>; Mention ***@***.***> Subject: Re: [OutSystems/outsystems-maps] fix(marker-manager): prevent invalid array splicing and improve marker cleanup safety (PR #217) You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> [https://avatars.githubusercontent.com/u/29493222?s=20&v=4]gnbm left a comment (OutSystems/outsystems-maps#217)<#217 (comment)> Hello @promonteiro<https://github.com/promonteiro> 👋 Thanks for your Pull Request. It looks like this may be your first contribution to an OutSystems Open Source project. Before we look into your contribution, we need you to accept the 📝 OutSystems Contributors License Agreement<https://outsystems-public-dl.s3-eu-west-1.amazonaws.com/opensource/cla/OutSystems-Contributor-License-Agreement-2020-03-23.pdf>. After you read and accept the terms of the agreement, reply to this message saying I read, understood and accept the OutSystems CLA. After this step, we'll review your Pull Request and provide any feedback if needed. Thank you and feel free to keep contributing! 🚀 — Reply to this email directly, view it on GitHub<#217 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BN5LJN7T3MSDMD6CHBK5BYT4FLOXDAVCNFSM6AAAAACQYLQZ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJSGI3DKMZWGE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[gnbm]

@promonteiro All commits on our repos are required to be signed

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[promonteiro]

Hey folks! Sorry for the noise on this PR. I haven’t used git in a while and I was a bit lost on how to properly sign the commits for the PR, so I had to force-push after re-signing. It should now be correctly signed/verified. Thanks for your patience!