Skip to content

fix: assign product quantities by id match instead of index in addNew… #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZIADMOHAMED-A8 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

fix: assign product quantities by id match instead of index in addNew… #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/controllers/cart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ export const addNewCart = ({ userId, products = [] }) => {
let totalQuantity = 0;

// get products in the relevant schema
const someProducts = productsByIds.map((p, idx) => {
// get quantity of the product
const quantity = productQty[idx];
const someProducts = productsByIds.map((p) => {
const originalIndex = productIds.indexOf(p.id); // match by id
const quantity = productQty[originalIndex];

// total price (price * quantity)
const priceWithQty = p.price * quantity;
Expand Down Expand Up @@ -219,4 +219,4 @@ export const deleteCartById = ({ id }) => {
cart.deletedOn = new Date().toISOString();

return cart;
};
};